Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): fixes #208 by compiling without Ivy #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhuber2010
Copy link

@bhuber2010 bhuber2010 commented Jul 9, 2020

** PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?
Library can not be used in pre-Ivy projects

Issue Number: #208

** What is the new behavior?
Library works in pre-Ivy projects

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

** Other information
It's currently not recommended to build libraries with Ivy due to potentially losing support for ViewEngine compiled Angular projects.

@bhuber2010 bhuber2010 requested a review from fulls1z3 as a code owner July 9, 2020 19:08
@ghost
Copy link

ghost commented Jul 9, 2020

Warnings are found on analyzing the commit fee1501.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files           7        7           
  Lines         161      161           
  Branches       47       47           
=======================================
  Hits          159      159           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6329569...fee1501. Read the comment docs.

@fulls1z3
Copy link
Owner

fulls1z3 commented Jul 8, 2021

@bhuber2010 need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

and finally we're showcasing it on fulls1z3/universal#755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants