Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several small improvements, mostly to make and release #81

Merged
merged 3 commits into from Jul 31, 2020

Conversation

jhump
Copy link
Contributor

@jhump jhump commented Jul 31, 2020

This brings over some recent improvements that were made in the grpcurl repo:

  1. Fix all Makefile targets so that make ci does not try to auto-update pinned dependencies to newer versions but instead uses the versions indicated in go.mod.
  2. Update to latest grpcurl. Also updates to recent Google API module (work around same build issue for goreleaser as in make release work grpcurl#179).
  3. Adds same anonymous imports as used by grpcurl, which adds support for message compression in gRPC calls as well as support for the "xds" URI scheme.

The update to latest grpcurl also ensures that this repo is compatible with the latest grpc-go (which recently deleted a package that was referenced by older grpcurl). See fullstorydev/grpcurl#178 for more details.


This just in: this also removes Go 1.11 without modules from the Travis CI matrix. When not running in modules mode, CI go gets the latest version of all dependencies. But the latest grpc module no longer supports Go 1.11.

Here's an example red build (which just happened on master): https://travis-ci.com/github/fullstorydev/grpcui/jobs/366918490

Copy link
Member

@dragonsinth dragonsinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We should copy some of the travis and make stuff -> gosolr I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants