Bundle packages that could not be resolved at build time

Update webpack externals configuration, so that we fallback to webpack to handle the dependency in case its absolute path could not be resolved using the node.js resolver at build time (as opposed to assuming that the dependency may be available later at runtime). This also ensures a failing build in case the requested module is missing, which in turn prevents bad deployments using "defective" build artifacts.

This specifically fixes a scenario where the requested package is a local workspace that requires some build transforms, as it is consumed directly from sources (e.g., a local workspace authored in TypeScript).

fusion-cli-tests/package.json

@@ -19,7 +19,9 @@
     "eventsource": "^2.0.1",
     "fixture-es2017-pkg": "0.0.0-monorepo",
     "fixture-macro-pkg": "0.0.0-monorepo",
+    "fixture-pkg": "0.0.0-monorepo",
     "fixture-pure-esm-pkg": "0.0.0-monorepo",
+    "fixture-typescript-local-pkg": "0.0.0-monorepo",
     "flow-bin": "^0.131.0",
     "fusion-core": "0.0.0-monorepo",
     "fusion-plugin-apollo": "0.0.0-monorepo",

fusion-cli-tests/test/e2e/tree-shaking-flow/fixture/.gitignore

@@ -1,2 +1 @@
-!node_modules
 .fusion_babel_cache/

fusion-cli-tests/test/e2e/typescript/fixture/src/root.tsx

@@ -1,5 +1,11 @@
 import React from 'react';
+import test from 'fixture-typescript-local-pkg/test';
 
 const TITLE: string = 'TypeScript';
 
-export default <h1>{TITLE}</h1>;
+export default (
+  <>
+    <h1>{TITLE}</h1>
+    <h2>{test}</h2>
+  </>
+);

fusion-cli-tests/test/e2e/typescript/test.js

@@ -29,6 +29,7 @@ describe('TypeScript app', () => {
     await page.goto(`http://localhost:${port}/`, {waitUntil: 'load'});
     const content = await page.content();
     t.ok(content.includes('TypeScript'));
+    t.ok(content.includes('FIXTURE_TYPESCRIPT_LOCAL_PACKAGE_CONTENT'));
 
     browser.close();
     proc.kill('SIGKILL');
@@ -45,6 +46,7 @@ describe('TypeScript app', () => {
     await page.goto(`${url}/`, {waitUntil: 'load'});
     const content = await page.content();
     t.ok(content.includes('TypeScript'));
+    t.ok(content.includes('FIXTURE_TYPESCRIPT_LOCAL_PACKAGE_CONTENT'));
 
     await app.teardown();
   }, 15000);

fusion-cli/build/get-webpack-config.js

@@ -641,10 +641,14 @@ function getWebpackConfig(opts /*: WebpackConfigOpts */) {
 
             if (/^[@a-z\-0-9]+/.test(request)) {
               const absolutePath = getModuleAbsolutePath(context, request);
-              // do not bundle external packages and those not whitelisted
-              if (typeof absolutePath !== 'string') {
-                // if module is missing, skip rewriting to absolute path
-                return handleExternalResult(request);
+              if (!absolutePath) {
+                // bundle the dependency if absolute path could not be determined
+                // using node.js resolver at build time. This will ensure a build
+                // failure in case the dependency is missing, as opposed to making
+                // an assumption that the dependency will be available at runtime.
+                // And will also fallback to webpack for resolving, and building a
+                // module imported from a local workspace (monorepo support).
+                return handleExternalResult();
               }
 
               if (experimentalBundleTest) {
@@ -664,8 +668,11 @@ function getWebpackConfig(opts /*: WebpackConfigOpts */) {
                   );
                 }
               }
+
+              // do not bundle external packages
               return handleExternalModule(absolutePath);
             }
+
             // bundle everything else (local files, __*)
             return handleExternalResult();
           }