Skip to content

Commit

Permalink
For the connected router plugin, pin fusion-plugin-react-router to 2.3.3
Browse files Browse the repository at this point in the history
This PR is in preparation of upgrading `react-router` inside of `fusion-plugin-react-router` to 6.x.

`connected-router` does not support react-router 6 and going by the github repo commits and issues, they have no plans to. See supasate/connected-react-router#543. Seems like community members are migrating to other solutions.

In lieu of this, this PR pins this plugin to the latest version of `fusion-plugin-react-router` to serve as a time capsule for whomever still wants to use this. That way when we upgrade `fusion-plugin-react-router` it won't break this plugin.

Alternatively, there is potential work to migrate this plugin to use something else under the hood that supports react router 6 but to me that should be an entirely new plugin instead of continuing to work on this one.
  • Loading branch information
derekju authored and fusionjs-sync-bot[bot] committed Feb 17, 2022
1 parent daf381d commit e5ae098
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions fusion-plugin-connected-react-router/package.json
Expand Up @@ -22,7 +22,8 @@
"flow-bin": "^0.109.0",
"fusion-cli": "0.0.0-monorepo",
"fusion-core": "0.0.0-monorepo",
"fusion-plugin-react-router": "0.0.0-monorepo",
"fusion-plugin-react-router": "2.3.3",
"fusion-plugin-universal-events": "0.0.0-monorepo",
"fusion-react": "0.0.0-monorepo",
"fusion-test-utils": "0.0.0-monorepo",
"get-port": "^5.1.1",
Expand Down Expand Up @@ -55,7 +56,7 @@
"peerDependencies": {
"connected-react-router": "^6.5.0",
"fusion-core": "0.0.0-monorepo",
"fusion-plugin-react-router": "0.0.0-monorepo",
"fusion-plugin-react-router": "2.3.3",
"react": "^16.12.0",
"react-dom": "^16.12.0",
"redux": "^4.0.5"
Expand Down

0 comments on commit e5ae098

Please sign in to comment.