Add HA etcd sample #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alaypatel07 we would like create a HA deployment of etcd to aid us with observing ocp migrations and teasing out issues. Do you have any suggestions for improving this example to make it a better representation of an ha etcd deployment? |
alaypatel07
reviewed
Mar 13, 2019
alaypatel07
reviewed
Mar 13, 2019
alaypatel07
reviewed
Mar 13, 2019
alaypatel07
reviewed
Mar 13, 2019
There was a problem hiding this comment.
@jwmatthews @alexander-demichev Overall looks good. Added few NITs for running it in ha
alaypatel07
requested changes
Mar 13, 2019
alaypatel07
requested changes
Mar 14, 2019
| --listen-peer-urls http://0.0.0.0:2380 \ | ||
| --listen-client-urls http://0.0.0.0:2379 \ | ||
| --advertise-client-urls http://${HOSTNAME}.etcd:2379 \ | ||
| --initial-advertise-peer-urls http://${HOSTNAME}:2380 \ |
There was a problem hiding this comment.
This needs to be --initial-advertise-peer-urls http://${HOSTNAME}.etcd:2380 \
alexander-demicev
force-pushed
the
etcd
branch
2 times, most recently
from
a56cea8
to
0ccd0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 node HA etcd sample