バージョンアップ時にタグとリリースの作成を自動で行う #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
reviewed
Oct 27, 2023
| const tags = cp.execSync("git tag").toString().split("\n"); | ||
| const changelog = readFileSync("CHANGELOG.md", "utf8"); | ||
|
|
||
| const latestVersion = changelog.match(/^## (?<version>\d\.\d\.\d)/m); |
There was a problem hiding this comment.
CHANGELOG.mdから取るよりもpackage.jsonから取得する方が簡単ではないでしょうか？
There was a problem hiding this comment.
確かにそちらの方が簡単ですね！
後ほど修正しようと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changesets/actionはタグとリリースを作成する前にnpm publishを実行する前提になっており、vscode-uroborosql-fmtはリリース時にnpm publishを実行しないため、バージョンアップ時にgithub actionでタグとリリースを作成出来ていなかった。
このissueを参考に、バージョンアップ時にgithub actionでタグとリリースを自動的に作成するよう対応する。
#21