Windows support #171
Open
Windows support #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These change adds Windows support to the Pepperoni App Kit.
chadrien
reviewed
Jan 23, 2017
| @@ -0,0 +1,9 @@ | |||
| { | |||
There was a problem hiding this comment.
Looks like the vscode configuration file to get javascript intellisense, not sure it should be there. Was it committed on purpose?
There was a problem hiding this comment.
No, forgot to remove it...will remove it.
|
@anidel thanks for submitting the PR :) Could you rebase on master and resolve the current conflicts before we merge it in? Would also still need to test it properly. |
tino-junge
suggested changes
Mar 4, 2017
There was a problem hiding this comment.
Reviewed now again and tested the app on windows. It would be great if we could add a travis build config as well for UWP. 2 issues I found so far:
- the app doesn't build because of a bug in react-native-windows 41
ReactTextShadowNode.cs:234
I fixed it by replacing it with the following:
textBlock.FontFamily = _fontFamily != null ? new FontFamily(_fontFamily) : new FontFamily("XamlAutoFontFamily”);
- vector icons are not yet displayed correctly. Might have to be added to build path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #63