Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yew from 0.20 to 0.21 #141

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Update yew from 0.20 to 0.21 #141

merged 4 commits into from
Oct 6, 2023

Conversation

langyo
Copy link
Contributor

@langyo langyo commented Sep 30, 2023 •
edited

18 hours ago :P

All the unit tests were passed and it was built successfully

futursolo
futursolo approved these changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

futursolo
futursolo requested changes Oct 1, 2023
View reviewed changes
Copy link
Owner

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that CI has failed for some tests. Could you please fix CI?

@langyo
Copy link
Contributor Author

langyo commented Oct 1, 2023

It looks like that CI has failed for some tests. Could you please fix CI?

Sure, wait a while

@langyo langyo requested a review from futursolo October 1, 2023 17:04
@langyo
Copy link
Contributor Author

langyo commented Oct 4, 2023

#142 Oh, a bot
image

futursolo
futursolo reviewed Oct 5, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@langyo @futursolo
Update CHANGELOG.md
d6501a2 
Co-authored-by: Kaede Hoshikawa <futursolo@users.noreply.github.com>
@langyo langyo requested a review from futursolo October 5, 2023 13:54
futursolo
futursolo approved these changes Oct 6, 2023
View reviewed changes
Copy link
Owner

@futursolo futursolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@futursolo futursolo merged commit 0a4a583 into futursolo:master Oct 6, 2023
6 checks passed
@langyo langyo deleted the yew-0.21-up branch October 6, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futursolo futursolo futursolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langyo @futursolo