Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non_upper_case_globals lint in some cases #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WorldSEnder
Copy link
Collaborator

This was never reported as a bug, but mentioned on the discord, that sometimes the macro emits warnings that can be ignored with #![allow(non_upper_case_globals)]. I believe the culprit in the situation is the emitted const _: when parts of the style AST can be constructed at compile time.

I've added a small comment on the usage of Span::mixed_site() for future reference too, since I had to look that up when editing.

@WorldSEnder
Copy link
Collaborator Author

MSRV test failure seems to come from a downstream package, i.e. toml_datetime requiring 1.67 compared to the tested 1.65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant