Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jabra-gnp: Adds support to OTA updates. Includes some bug fixes #7151

Merged
merged 1 commit into from May 15, 2024

Conversation

gdpcastro
Copy link
Collaborator

Type of pull request:

@gdpcastro
Copy link
Collaborator Author

I could maybe use some advice regarding the "framework" around child devices - as I went with what seemed the most reasonable, but I do get a small issue currently. After the update is done on a child device (that is a device connected to one of our dongles), I get a message from fwupdtool "device version not updated on success, V1 != V2".
The version is updated, but I imagine fwupdtool queries for the new version before the device reconnects itself.

@gdpcastro gdpcastro changed the title Adds support to OTA updates. Includes some bug fixes Jabra-gnp: Adds support to OTA updates. Includes some bug fixes Apr 23, 2024
@hughsie
Copy link
Member

hughsie commented Apr 23, 2024

@gdpcastro I think the device version not updated on success is because the parent and the child have the same device-id -- I think you meant to set the logical ID to ota_device.

I've pushed a fixup and probably broken a few things, but be helpful in showing you the way to do this. I hope it's helpful!

@gdpcastro
Copy link
Collaborator Author

I'm going to be on vacation for some days, so this will be on hold for around a week

@gdpcastro
Copy link
Collaborator Author

@gdpcastro I think the device version not updated on success is because the parent and the child have the same device-id -- I think you meant to set the logical ID to ota_device.

I still get device version not updated on success, 1.7.4 != 1.8.13 - might be a problem with the fact that the ota device takes a second to re-pair to the dongle. Not entirely sure how to address it properly. I did try adding some waiting times, but to no avail

@hughsie
Copy link
Member

hughsie commented May 8, 2024

might be a problem with the fact that the ota device takes a second to re-pair to the dongle

I think we're missing a fu_device_add_flag(child, FWUPD_DEVICE_FLAG_WAIT_FOR_REPLUG); somewhere -- i.e. just before the child device "goes away" and "comes back" from the daemon. If the child device never really goes away, then fu_device_sleep() in ->reload() might be your friend.

Copy link
Member

@hughsie hughsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdpcastro I've made a few cosmetic changes, and squashed everything down. Can you test one more time and then please merge. Thanks!

@gdpcastro
Copy link
Collaborator Author

Tests went through :) Merging!

@gdpcastro gdpcastro merged commit bcaf325 into main May 15, 2024
18 checks passed
@gdpcastro gdpcastro deleted the jabra/jabra-gnp-updates branch May 15, 2024 04:39
chenhn123 pushed a commit to chenhn123/fwupd that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants