-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jabra-gnp: Adds support to OTA updates. Includes some bug fixes #7151
Conversation
I could maybe use some advice regarding the "framework" around child devices - as I went with what seemed the most reasonable, but I do get a small issue currently. After the update is done on a child device (that is a device connected to one of our dongles), I get a message from fwupdtool "device version not updated on success, V1 != V2". |
@gdpcastro I think the I've pushed a fixup and probably broken a few things, but be helpful in showing you the way to do this. I hope it's helpful! |
I'm going to be on vacation for some days, so this will be on hold for around a week |
I still get |
I think we're missing a |
868d0de
to
ee1447a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gdpcastro I've made a few cosmetic changes, and squashed everything down. Can you test one more time and then please merge. Thanks!
Tests went through :) Merging! |
Type of pull request: