Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial: ci: install coverage #7187

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

trivial: ci: install coverage #7187

wants to merge 6 commits into from

Conversation

superm1
Copy link
Member

@superm1 superm1 commented Apr 29, 2024

hopefully fixes coveralls

Type of pull request:

@superm1 superm1 marked this pull request as draft April 29, 2024 15:26
@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

Well so that's interesting - it fails on 0.6.9 too! I wonder if this is a fwupd problem.

@hughsie
Copy link
Member

hughsie commented Apr 29, 2024

@superm1 what does coverage.xml show? Is it an empty file or something weird perhaps?

@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

@superm1 what does coverage.xml show? Is it an empty file or something weird perhaps?

let's see, I just changed the job to save it to artifacts so we can tell.

@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

It's empty!

@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

My conclusion from that finding is something must have changed in the Debian container that broke coverage. It just starts to show up today because containers regenerated about 16 hours ago.

@hughsie
Copy link
Member

hughsie commented Apr 29, 2024

something must have changed in the Debian container

Can we compare the .debs that were used in each?

@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

It's a bit difficult to run diff on without some fancy pants filtering tools. You got any good ways?

old_2_push_to_registry (debian-x86_64).txt
new_2_push_to_registry (debian-x86_64).txt

@superm1
Copy link
Member Author

superm1 commented Apr 29, 2024

But at least for the biggies.

  • Same gcovr version 7.0-1
  • Same GCC 13.2.0-23

@hughsie
Copy link
Member

hughsie commented May 1, 2024

It's a bit difficult to run diff on without some fancy pants filtering tools. You got any good ways?

I've got python! :) Easier files to diff attached -- but no smoking gun.

old.txt
new.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants