Only read back the thunderbolt firmware if we can parse the NVM #7206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsie
force-pushed
the
hughsie/tbt-no-dump
branch
2 times, most recently
from
d373132
to
1064ba0
Compare
4 tasks
We fallback from FuIntelThunderboltFirmware to FuFirmware for non-controller devices, and for this there's no point taking 10 seconds to dump the old NVM firmware.
This allows us to set the device status (and maybe the percentage in the future) when dumping the firmware from the device.
hughsie
force-pushed
the
hughsie/tbt-no-dump
branch
from
1064ba0
to
0021a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fallback from FuIntelThunderboltFirmware to FuFirmware for non-controller devices, and for this there's no point taking 10 seconds to dump the old NVM firmware.
Type of pull request: