FPC: Update to support FPC firmware format version 2 #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you attach (or email me) a sample ff2 firmware file please? |
hughsie
reviewed
May 10, 2024
hughsie
reviewed
May 10, 2024
hughsie
reviewed
May 10, 2024
|
Sorry for the late comment. I have tested the commits, it works properly with new and old format firmware updates. Thanks a lot. |
hughsie
approved these changes
May 16, 2024
|
@haoweilo do you need this in the 1.9.x branch too? e.g. for ChromeOS? |
|
@hughsie When would 2.0 be released? We have few customer projects with new format will be tested on ubuntu 22.04. Does that mean it needs to be merged to 1.9.x branch as well? Thanks. |
|
There is one commit that I push to fix the progress error not be merged into main. |
haoweilo
commented
May 16, 2024
|
2.0.0 is an API break release so it's not going to be backported into older distros. It sounds like you do want a backport. Can you check if #7263 works please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support new firmware format for latest devices.
Type of pull request: