Add weida raw plugin #7247
Closed
Add weida raw plugin #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 3, 2024 06:35
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
| return FALSE; | ||
| self->firmware_id = fu_memread_uint32(&buf[1], G_LITTLE_ENDIAN); | ||
| self->hardware_id = fu_memread_uint32(&buf[5], G_LITTLE_ENDIAN); | ||
| self->serial_number = fu_memread_uint32(&buf[9], G_LITTLE_ENDIAN); |
There was a problem hiding this comment.
fu_device_set_serial_number() here (with a string)
There was a problem hiding this comment.
ohh you do, ignore me. I think in this case don't store the serial_number in self, just read it locally to this function
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 13, 2024
hughsie
reviewed
May 17, 2024
This allows us to set the device status (and maybe the percentage in the future) when dumping the firmware from the device.
Signed-off-by: Richard Hughes <richard@hughsie.com>
Signed-off-by: Richard Hughes <richard@hughsie.com>
Added GUID constructed from the Alias. In case if the device has no Modailas property the VID is not set, and the Alias-based name allows to clearly match the device: e3dfc8e1-e923-55b1-a2b7-1c6d82e312d2 <- BLUETOOTH\ALIAS_CCC5171 Used Alias property instead of the Name, since BlueZ documentation has the comment for the Name property: "This value is only present for completeness. It is better to always use the Alias property when displaying the devices name. If the Alias property is unset, it will reflect this value which makes it more convenient." https://github.com/luetzel/bluez/blob/master/doc/device-api.txt#L123
Some BT devices don't provide VID, so fwupd can't detect such devices properly. In the same time, the device might announce service with unique UUID for firmware upgrading. This commit allows to detect BT devices by UUID of the updating service, for instance: 21608f80-6c9c-5cd1-91ed-0fbf18e31958 ← BLUETOOTH\GATT_00001100-d102-11e1-9b23-00025b00a5a5 In addition, added querying of Battery service if available, and battery percentage is set according to received value If Device Information service is available it might also contain useful information for device identification, see https://www.bluetooth.com/specifications/dis-1-2/ for a full list. Also, allow to acquire write and notify for BlueZ devices, which allows us to interact with the device directly via file descriptor without D-Bus usage for every data portion.
Signed-off-by: Richard Hughes <richard@hughsie.com>
This should fix flashing the wacom_usb touch module. Resolves: fwupd#7267
For some unknown [UNIX?] reason, setting the environment variable does not work after setting up the SIGINT handler. Just do the latter later in the startup process.
|
@chenhn123 I've sent you an invite to the project, and will create a new |
|
Lets carry on in #7275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Checklist
README.mdwith update protocolREADME.mdwith any custom quirks and flagsREADME.mdwith the vendor ID security valueFuFirmware->write()and include at least one fuzzer testcase insrc/fuzzing/firmwarefor any customFuFirmwaresubclass