This repository has been archived by the owner on Jan 27, 2024. It is now read-only.
Add ListWithData tutorial #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
suggested changes
Oct 17, 2021
| Well first thing first, let's start by defining our binding in our app : | ||
|
|
||
| ```go | ||
| var ContactListBinding binding.UntypedList = binding.NewUntypedList() |
There was a problem hiding this comment.
best not to export variables unless required
There was a problem hiding this comment.
Also here you should define the struct contact or whatever.
For the rest of the example can you use a local type rather than contact.Contact?
| @@ -139,6 +139,9 @@ entries: | |||
| - title: Add a Custom Theme | |||
| url: /tutorial/custom-theme | |||
| output: web, pdf | |||
| - title: List of struct and ListWithData widget | |||
There was a problem hiding this comment.
Can you think of a shorter title?
"ListWIthData using custom struct" perhaps?
| return container.NewVBox(widget.NewLabel(""), widget.NewLabel(""), widget.NewLabel(""), widget.NewLabel("")) | ||
| }, | ||
| func(di binding.DataItem, co fyne.CanvasObject) { | ||
| v, _ := di.(binding.Untyped).Get() |
There was a problem hiding this comment.
I wonder if it is worth using s := binding.BindStruct(v.(*contact)).
Then a label could be bound using Label.Bind(s.GetItem("FirstName").(binding.String)) I think?...
It would remove the code where you set up new strings and then bind them - making a proper connection to the source data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.