Merge pull request #248 from nobe4/fix-missing-requirement

fix: update install suggestion for missing `fyne` command
fyne-io · May 7, 2024 · 187fb53 · 187fb53
2 parents 5448401 + 26515d9
commit 187fb53
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -131,11 +131,9 @@ jobs:
         working-directory: fyne-cross
         run: go install
 
-        # attempt to use "go install" but fallback to "go get"
       - name: Install Fyne
         run: |
-          go install fyne.io/fyne/v2/cmd/fyne@latest ||
-          go get fyne.io/fyne/v2/cmd/fyne@latest
+          go install fyne.io/fyne/v2/cmd/fyne@latest
 
       - name: Install Podman
         if: ${{ runner.os == 'macos' }}
@@ -213,11 +211,9 @@ jobs:
         working-directory: fyne-cross
         run: go install
 
-        # attempt to use "go install" but fallback to "go get"
       - name: Install Fyne
         run: |
-          go install fyne.io/fyne/v2/cmd/fyne@latest ||
-          go get fyne.io/fyne/v2/cmd/fyne@latest
+          go install fyne.io/fyne/v2/cmd/fyne@latest
 
       - name: Install Podman
         if: ${{ runner.os == 'macos' }}

diff --git a/internal/command/command.go b/internal/command/command.go
@@ -157,7 +157,7 @@ func printUsage(template string, data interface{}) {
 func checkFyneBinHost(ctx Context) (string, error) {
 	fyne, err := execabs.LookPath("fyne")
 	if err != nil {
-		return "", fmt.Errorf("missed requirement: fyne. To install: `go get fyne.io/fyne/v2/cmd/fyne` and add $GOPATH/bin to $PATH")
+		return "", fmt.Errorf("missed requirement: fyne. To install: `go install fyne.io/fyne/v2/cmd/fyne@latest` and add $GOPATH/bin to $PATH")
 	}
 
 	if debugging() {