New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for "fyne release" #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work getting this together thanks.
I see that iOS and Windows release build is called on the host, so I guess this means that they can lookup the keystore / key file for the signing.
However the Android build asks for a keystore path - is that accessible from the runtime ? (It may be outside the project) - and it will ask for the password on the command line, does that work in this model?
I was a little confused as fyneRelease vs fyneReleaseHost seems to have duplicated code but as I understand it the former is just android? In which location do linux/bsd releases run?
Right, it is basically a wrapper for
Yes, but it can only access files inside the project. Mounting of external files or directories is not supported yet.
Good catch, no won't work. We need to specify the password with a flag like for Windows. If this is not supported by
Yep, I was unsure about the naming too. Tempted to add the TD;DR |
This version of fyne-cli allows to specify custom build tags (fyne-io#1538)
Testing locally, did a --pull, but I don't think the bundled fyne is new enough?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
For the record this was an out of date local fyne, which is used by darwin release. |
This PR adds support for "fyne release"
Fixes #1