Allow custom themes to react theme variant changes, fixes #2006 (#2049)

fyne-io · Mar 1, 2021 · 93b3e48 · 93b3e48
1 parent a9fe32d
commit 93b3e48
Show file tree

Hide file tree

Showing 2 changed files with 76 additions and 14 deletions.
diff --git a/app/settings.go b/app/settings.go
@@ -139,26 +139,36 @@ func (s *settings) fileChanged() {
 }
 
 func (s *settings) setupTheme() {
-	if s.themeSpecified {
-		return
-	}
 	name := s.schema.ThemeName
 	if env := os.Getenv("FYNE_THEME"); env != "" {
-		s.themeSpecified = true
 		name = env
 	}
 
-	if name == "light" {
-		s.applyTheme(theme.LightTheme(), theme.VariantLight)
-	} else if name == "dark" {
-		s.applyTheme(theme.DarkTheme(), theme.VariantDark)
-	} else {
-		if defaultVariant() == theme.VariantLight {
-			s.applyTheme(theme.LightTheme(), theme.VariantLight)
-		} else {
-			s.applyTheme(theme.DarkTheme(), theme.VariantDark)
+	var variant fyne.ThemeVariant
+	effectiveTheme := s.theme
+	switch name {
+	case "light":
+		variant = theme.VariantLight
+		if !s.themeSpecified {
+			effectiveTheme = theme.LightTheme()
+		}
+	case "dark":
+		variant = theme.VariantDark
+		if !s.themeSpecified {
+			effectiveTheme = theme.DarkTheme()
+		}
+	default:
+		variant = defaultVariant()
+		if s.themeSpecified {
+			break
+		}
+		effectiveTheme = theme.DarkTheme()
+		if variant == theme.VariantLight {
+			effectiveTheme = theme.LightTheme()
 		}
 	}
+
+	s.applyTheme(effectiveTheme, variant)
 }
 
 func loadSettings() *settings {

diff --git a/app/settings_test.go b/app/settings_test.go
@@ -76,16 +76,68 @@ func TestOverrideTheme_IgnoresSettingsChange(t *testing.T) {
 	}
 	set.setupTheme()
 	assert.Equal(t, theme.LightTheme(), set.Theme())
+
+	err = set.loadFromFile(filepath.Join("testdata", "dark-theme.json"))
+	if err != nil {
+		t.Error(err)
+	}
+	set.setupTheme()
+	assert.Equal(t, theme.LightTheme(), set.Theme())
 	err = os.Setenv("FYNE_THEME", "")
 	if err != nil {
 		t.Error(err)
 	}
+}
+
+func TestCustomTheme(t *testing.T) {
+	type customTheme struct {
+		fyne.Theme
+	}
+	set := &settings{}
+	ctheme := &customTheme{theme.LightTheme()}
+	set.SetTheme(ctheme)
+
+	set.setupTheme()
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, defaultVariant(), set.ThemeVariant())
+
+	err := set.loadFromFile(filepath.Join("testdata", "light-theme.json"))
+	if err != nil {
+		t.Error(err)
+	}
+	set.setupTheme()
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, theme.VariantLight, set.ThemeVariant())
 
 	err = set.loadFromFile(filepath.Join("testdata", "dark-theme.json"))
 	if err != nil {
 		t.Error(err)
 	}
+	set.setupTheme()
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, theme.VariantDark, set.ThemeVariant())
 
+	err = os.Setenv("FYNE_THEME", "light")
+	if err != nil {
+		t.Error(err)
+	}
 	set.setupTheme()
-	assert.Equal(t, theme.LightTheme(), set.Theme())
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, theme.VariantLight, set.ThemeVariant())
+
+	err = os.Setenv("FYNE_THEME", "dark")
+	if err != nil {
+		t.Error(err)
+	}
+	set.setupTheme()
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, theme.VariantDark, set.ThemeVariant())
+
+	err = os.Setenv("FYNE_THEME", "")
+	if err != nil {
+		t.Error(err)
+	}
+	set.setupTheme()
+	assert.True(t, set.Theme() == ctheme)
+	assert.Equal(t, theme.VariantDark, set.ThemeVariant())
 }