fix slider.SetValue method, update TestSlider_OnChanged

fyne-io · Mar 23, 2021 · b307cea · b307cea
1 parent bfc7d10
commit b307cea
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/widget/slider.go b/widget/slider.go
@@ -176,9 +176,15 @@ func (s *Slider) SetValue(value float64) {
 		return
 	}
 
+	lastValue := s.Value
+
 	s.Value = value
 	s.clampValueToRange()
 
+	if lastValue == s.Value {
+		return
+	}
+
 	if s.OnChanged != nil {
 		s.OnChanged(s.Value)
 	}

diff --git a/widget/slider_test.go b/widget/slider_test.go
@@ -118,7 +118,8 @@ func TestSlider_VerticalLayout(t *testing.T) {
 }
 
 func TestSlider_OnChanged(t *testing.T) {
-	slider := NewSlider(0, 1)
+	slider := NewSlider(0, 2)
+	slider.Resize(slider.MinSize())
 	assert.Empty(t, slider.OnChanged)
 
 	changes := 0
@@ -130,9 +131,18 @@ func TestSlider_OnChanged(t *testing.T) {
 	assert.Equal(t, 0, changes)
 
 	slider.SetValue(0.5)
+	assert.Equal(t, 0, changes)
+
+	drag := &fyne.DragEvent{}
+	drag.PointEvent.Position = fyne.NewPos(25, 2)
+	slider.Dragged(drag)
+	assert.Equal(t, 1, changes)
+
+	drag.PointEvent.Position = fyne.NewPos(25, 2)
+	slider.Dragged(drag)
 	assert.Equal(t, 1, changes)
 
-	drag := &fyne.DragEvent{Dragged: fyne.NewDelta(10, 2)}
+	drag.PointEvent.Position = fyne.NewPos(50, 2)
 	slider.Dragged(drag)
 	assert.Equal(t, 2, changes)
 }