Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons aren't generated with the appropriate dimensions causing failure do distribute app #1498

Closed
MagicalTux opened this issue Nov 3, 2020 · 1 comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working

Comments

@MagicalTux
Copy link
Contributor

MagicalTux commented Nov 3, 2020

Describe the bug:

When uploading the generated ipa file to Apple, the following errors appear:

[2020-11-03 22:52:08 JST] <main> ERROR: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '76x76' pixels, in .png format for iOS versions >= 7.0. To support older operating systems, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"
[2020-11-03 22:52:08 JST] <main> ERROR: ERROR ITMS-90023: "Missing required icon file. The bundle does not contain an app icon for iPad of exactly '152x152' pixels, in .png format for iOS versions >= 7.0. To support older operating systems, the icon may be required in the bundle outside of an asset catalog. Make sure the Info.plist file includes appropriate entries referencing the file. See https://developer.apple.com/documentation/bundleresources/information_property_list/user_interface"

The bundle indeed contains files matching the required sized (Icon_76.png, Icon_152.png) but those files are actually 120x120 pixels images.

The issue comes from cmd/fyne/commands/package-mobile.go on line 37, where sips is invoked with a -Z value fixed to 120 while it should actually be size.

To Reproduce:

Steps to reproduce the behaviour:

  1. Build ipa file
  2. Upload with xcrun altool --upload-app

Device (please complete the following information):

  • OS: MacOS
  • Version: 10.15.7
  • Go version: 1.14.10
  • Fyne version: 1.4.0
@andydotxyz andydotxyz added blocker Items that would block a forthcoming release bug Something isn't working labels Nov 3, 2020
andydotxyz added a commit that referenced this issue Nov 3, 2020
fix #1498: resize parameter passed to sips to be the requested size
@andydotxyz
Copy link
Member

Thanks for the fix. It's on develop now and will be in the 1.4.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants