Fixes #1497 #1498 Skip build of darwin/arm and pass correct parameter to sips #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for looking into this. Unfortunately the arm fix needs a bigger change as the If you don't mind I would suggest you strip this back to the sips fix which is great and I can open a bigger PR for the arch fix which you could then help us test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1497 #1498: Skip build of darwin/arm and pass correct parameter to sips
Note that I haven't been able to test this due to the way go modules work. I'm not sure how to get this to work locally, and I am not sure if removing
darwin/armhas any impact on anything else.Checklist: