Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fyne doesn't remove temporary binary from src #1910

Closed
stuartmscott opened this issue Feb 6, 2021 · 7 comments
Closed

fyne doesn't remove temporary binary from src #1910

stuartmscott opened this issue Feb 6, 2021 · 7 comments
Labels
blocker Items that would block a forthcoming release bug Something isn't working

Comments

@stuartmscott
Copy link
Member

Describe the bug:

After running fyne get <package> a binary is left in the src directory.

To Reproduce:

Steps to reproduce the behaviour:

  1. fyne get aletheiaware.com/spacefynego/cmd/spacefyne
  2. Go on $GOPATH/src/aletheiaware/spacefynego
  3. Either run git status or ls cmd/spacefyne
  4. See the spacefyne binary

Device (please complete the following information):

  • OS: Ubuntu & MacOS
  • Version: 20.04 Focal & Big Sur
  • Go version: go1.15.7 linux/amd64 & go1.15 darwin/amd64
  • Fyne version: 9a0f87c
@stuartmscott stuartmscott added the bug Something isn't working label Feb 6, 2021
@Jacalz
Copy link
Member

Jacalz commented Feb 7, 2021

Seems to apply to the whole build command in itself when trying to package an application. Compiling with --release does not use a release compiled binary unless the one there is removed first.

@stuartmscott
Copy link
Member Author

Is --release different from fyne release?

@Jacalz
Copy link
Member

Jacalz commented Feb 7, 2021

Yes fyne package —release basically strips the debug symbols form the binaries and not much more, I think.

@stuartmscott
Copy link
Member Author

Oh thanks. It would be great if fyne release stripped debug symbols too. We also probably don't need two commands for creating releases. Though both of these should be separate tickets.

@Jacalz
Copy link
Member

Jacalz commented Feb 7, 2021

Yeah. We might want to have it as --strip-debug instead, or something along those lines. Like you say though, something for another ticket.

@andydotxyz
Copy link
Member

fyne release also strips symbols.
The difference between fyne release and fyne package —release is only the build artefact, in all other ways they are the same. The release mode is expected for distribution through official stores, package is for local instal or sharing on ad-hoc systems.

@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Mar 22, 2021
@andydotxyz
Copy link
Member

On release/v2.0.x for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants