Fix release builds not removing debug symbols #1918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
changed the title
Jacalz
force-pushed
the
fix-release-build
branch
from
ffefce8
to
cf57fb7
Compare
I noticed on my linux computer that packaging and adding `--release` has no effect. This change makes sure that the `-ldflags` call get the correct information.
|
This seems to have been caused by #1910. Will close this. Will have to punt the cleanups to some other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I noticed on my linux computer that packaging and adding
--releasehas no effect.This change tidies up the code a bit and makes sure that the
-ldflagscall get the correct information.I guess we might want this change for 2.0.1 as well, but that might not be possible to backport as is due to the changes after the cli rework.
Checklist: