Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When packaging an ampersand in "Name" causes an error #3195

Closed
2 tasks done
andrewheberle opened this issue Aug 9, 2022 · 1 comment
Closed
2 tasks done

When packaging an ampersand in "Name" causes an error #3195

andrewheberle opened this issue Aug 9, 2022 · 1 comment
Labels
bug Something isn't working OS:Windows Tickets affecting only Microsoft Windows

Comments

@andrewheberle
Copy link

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When packaging a Fyne app I cam across an issue where I had the application name in the FyneApp.toml containing an ampersand:

[Details]
  Icon = "logo.png"
  Name = "App With & In Name"
  ID = "com.example.app-with-ampersand-in-name"
  Version = "1.1.0"
  Build = 1

This resulted in an error The application has failed to start because its side-by-side configuration is incorrect. Please see the application event log or use the command-line sxstrace.exe tool for more detail similar to #1521

After reviewing the Windows Event Log there were entries showing Error in manifest or policy file "C:\path\to\app.exe" on line 2. Invalid Xml syntax

After replacing the & with and the issue went away.

I would assume the name is not being properly escaped in the generated manifest as an ampersand must be escaped as & in XML.

How to reproduce

  1. Create FyneApp.toml with Name containing and ampersand character
  2. Package using fyne package -os windows
  3. Attempt to run app

Screenshots

No response

Example code

No code example, issue is with app manifest generation of fyne command line tool.

Fyne version

2.2.3

Go compiler version

1.19

Operating system

Windows

Operating system version

Windows 11

Additional Information

No response

@andrewheberle andrewheberle added the unverified A bug that has been reported but not verified label Aug 9, 2022
@andydotxyz andydotxyz added bug Something isn't working OS:Windows Tickets affecting only Microsoft Windows and removed unverified A bug that has been reported but not verified labels Aug 11, 2022
@andydotxyz andydotxyz added this to the Fixes (v2.2.x) milestone Aug 11, 2022
andydotxyz added a commit to andydotxyz/fyne that referenced this issue Mar 12, 2023
@andydotxyz
Copy link
Member

Will be in v2.3.2 :)

andydotxyz added a commit that referenced this issue Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OS:Windows Tickets affecting only Microsoft Windows
Projects
None yet
Development

No branches or pull requests

2 participants