Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML Encode the windows XML data #3722

Merged
merged 3 commits into from Mar 12, 2023
Merged

XML Encode the windows XML data #3722

merged 3 commits into from Mar 12, 2023

Conversation

andydotxyz
Copy link
Member

Fixes #3195

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Mar 12, 2023 •
edited

Coverage Status

Coverage: 61.721% (+0.01%) from 61.711% when pulling ad59b28 on andydotxyz:fix/3195 into 79e5ad2 on fyne-io:develop.

@andydotxyz
Also fix when greater or less than symbols used
f86cccc 
Required not outputting name to icon file name as well
Jacalz
Jacalz requested changes Mar 12, 2023
View reviewed changes
cmd/fyne/internal/commands/encode.go
)

func encodeXMLString(in string) string {
return html.EscapeString(in)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the wrapper function nor the tests if we are to use the built in function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that HTML and XML are not actually the same I felt the clarity was helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@andydotxyz andydotxyz merged commit 2ff2298 into fyne-io:develop Mar 12, 2023
@andydotxyz andydotxyz deleted the fix/3195 branch March 12, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andydotxyz @coveralls @Jacalz