Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File dialog locations #1108

Closed
wants to merge 34 commits into from
Closed

File dialog locations #1108

wants to merge 34 commits into from

Commits on Jun 15, 2020

  1. file dialog: use ./ as start dir by default 

    This swaps ~/ and ./ as the default directory.

I have also made / the failover if both of those error. That *shouldn't*
happen though.

Note that / should be safe even on Windows, since NT supports
POSIX-style paths. `/` should expand to NTFS's root, which is almost
always `C:\`.

XXX: might be worth setting the failover dir in the platform driver. `/`
is probably not a good failover choice for iOS, although I'm not sure
the file dialog even makes sense there, since they have their own system
one? I'm not an iOS dev, so I'm not sure.
    @charlesdaniels
    charlesdaniels committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    9ec1249 View commit details
    Browse the repository at this point in the history

  2. file dialog: Add ShowFile*At methods 

    This adds the concept of a "starting directory", which may be set with a
new setter method. If there is a problem with this directory, or it is
an empty string, then the CWD is preferred, followed by the user home,
followed by `/`.

This also adds two new utility methods, ShowFileOpenAt, and
ShowFileSaveAt which allow the starting directory to be explicitly set
as arguments.

This should not break the existing API.
    @charlesdaniels
    charlesdaniels committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    d0e337a View commit details
    Browse the repository at this point in the history

  3. fixed linter errors

    @charlesdaniels
    charlesdaniels committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    c5561ca View commit details
    Browse the repository at this point in the history

  4. file dialog: break out effectiveStartingDir 

    Per @andydotxyz I have moved the logic to calculate the starting
directory for the file dialog widget to it's own function.
    @charlesdaniels
    charlesdaniels committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    db857e1 View commit details
    Browse the repository at this point in the history

  5. add tests for effectiveStartingDir()

    @charlesdaniels
    charlesdaniels committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    6fbdb2f View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. break out just effectiveStartingDir 

    This implements just the effectiveStartingDir() and a basic test from PR fyne-io#1108.
It does provide the ability to set a custom starting dir.

Cherry picked from fyne-io#1111 to fyne-io#1108 to avoid future merge conflicts.
    @charlesdaniels
    charlesdaniels committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    be9c018 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into file_dialog_locations

    @charlesdaniels
    charlesdaniels committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    a20d4ed View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Merge branch 'develop' into file_dialog_locations

    @charlesdaniels
    charlesdaniels committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    ec1f970 View commit details
    Browse the repository at this point in the history

  2. make public API use ListableURI

    @charlesdaniels
    charlesdaniels committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7794089 View commit details
    Browse the repository at this point in the history

  3. fix conditional check for ./

    @charlesdaniels
    charlesdaniels committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7ee7b21 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Migrate file dialog to use URIs throughout

    @charlesdaniels
    charlesdaniels committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7a4a4a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. feedback for fyne-io#1108

    @charlesdaniels
    charlesdaniels committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    78c6984 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into file_dialog_locations

    @charlesdaniels
    charlesdaniels committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    689a256 View commit details
    Browse the repository at this point in the history

  3. try to fix WIndows build failures

    @charlesdaniels
    charlesdaniels committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    e8a2269 View commit details
    Browse the repository at this point in the history

  4. try again to fix Windows build failure

    @charlesdaniels
    charlesdaniels committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    59c5fb7 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. try to implement Windows path support

    @charlesdaniels
    charlesdaniels committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    de97723 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into file_dialog_locations

    @charlesdaniels
    charlesdaniels committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    bc607aa View commit details
    Browse the repository at this point in the history

  3. fix staticcheck errors

    @charlesdaniels
    charlesdaniels committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    4d39cfd View commit details
    Browse the repository at this point in the history

  4. try to fix windows paths

    @charlesdaniels
    charlesdaniels committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    d46f9ff View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Fix some issues related to ListableURI and dialog

    @PucklaJ
    PucklaJ committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    210fe34 View commit details
    Browse the repository at this point in the history

  2. Replace fws with bws in setDirectory for windows

    @PucklaJ
    PucklaJ committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    2916628 View commit details
    Browse the repository at this point in the history

  3. Fix save and open dialog tests

    @PucklaJ
    PucklaJ committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9c055c7 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1 from PucklaMotzer09/file_dialog_locations_fixes 

    Fix some issues related to ListableURI and dialog
    @charlesdaniels
    charlesdaniels committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f3e0660 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2020

  1. Replace backslashes in NewURI

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    347e49a View commit details
    Browse the repository at this point in the history

  2. Add tests for parentGeneric

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    5681882 View commit details
    Browse the repository at this point in the history

  3. Improve tests and always end Parent with slash

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    60a46e4 View commit details
    Browse the repository at this point in the history

  4. Don't return as soon as one fails in loadFavorites

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    b7a6dd8 View commit details
    Browse the repository at this point in the history

  5. Update breadcrumbs creation and add test for them

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    20cbea5 View commit details
    Browse the repository at this point in the history

  6. Remove checking for "file" scheme in setDirectory

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    dc79d37 View commit details
    Browse the repository at this point in the history

  7. Fix staticcheck

    @PucklaJ
    PucklaJ committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    d5ce136 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Merge pull request #2 from PucklaMotzer09/file_dialog_locations 

    File dialog locations
    @charlesdaniels
    charlesdaniels committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    ac81a66 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. revert starting dir to ~, remove OpenAt functions

    @charlesdaniels
    charlesdaniels committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    45233fe View commit details
    Browse the repository at this point in the history

  2. re-enable overwrite callback

    @charlesdaniels
    charlesdaniels committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    ae3b91f View commit details
    Browse the repository at this point in the history

  3. update file dialog tests for ~ starting dir

    @charlesdaniels
    charlesdaniels committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    5b5c3a3 View commit details
    Browse the repository at this point in the history