File dialog wd #1111
Merged
File dialog wd #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This swaps ~/ and ./ as the default directory. I have also made / the failover if both of those error. That *shouldn't* happen though. Note that / should be safe even on Windows, since NT supports POSIX-style paths. `/` should expand to NTFS's root, which is almost always `C:\`. XXX: might be worth setting the failover dir in the platform driver. `/` is probably not a good failover choice for iOS, although I'm not sure the file dialog even makes sense there, since they have their own system one? I'm not an iOS dev, so I'm not sure.
This implements just the effectiveStartingDir() and a basic test from PR fyne-io#1108. It does provide the ability to set a custom starting dir.
andydotxyz
approved these changes
Jun 16, 2020
charlesdaniels
added a commit
to charlesdaniels/fyne
that referenced
this pull request
Jun 16, 2020
This implements just the effectiveStartingDir() and a basic test from PR fyne-io#1108. It does provide the ability to set a custom starting dir. Cherry picked from fyne-io#1111 to fyne-io#1108 to avoid future merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is just the part of #1108 that changes the default starting directory to
./, pulled out per @andydotxyz and @okratitanChecklist:
Where applicable: