Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix position of a window that is re-shown #1124

Merged
merged 2 commits into from Jun 22, 2020
Merged

Fix position of a window that is re-shown #1124

merged 2 commits into from Jun 22, 2020

Conversation

andydotxyz
Copy link
Member

Also we don't have to recreate the window either, waste of CPU
Fixes #1116

Checklist:

  • Tests included. <- couldn't test without showing windows and moving them around :(
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Fix position of a window that is re-shown
fa30f63 
Also we don't have to recreate the window either, waste of CPU
Fixes fyne-io#1116
Jacalz
Jacalz approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I don’t see anything that would be incorrect :)

@andydotxyz andydotxyz merged commit 33c346c into fyne-io:develop Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @Jacalz