Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure slider values are within range even on initial display #1134

Merged
merged 1 commit into from Jun 25, 2020
Merged

Ensure slider values are within range even on initial display #1134

merged 1 commit into from Jun 25, 2020

Conversation

andydotxyz
Copy link
Member

Description:

Fix for the slider initially appearing out of bounds if 0 was not in the slider range.

Fixes #1128

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Ensure slider values are within range even on initial display
67fbf83 
This was previously applied only on drag.
Fixed fyne-io#1128
Jacalz
Jacalz approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works great and definitely fixes my issue. Thanks 👍

@andydotxyz andydotxyz merged commit 61f02f5 into fyne-io:develop Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @Jacalz