dependencies: update glfw to 20200625191551 #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: pr-285 Fixes a compiler error by using null joystick on freebsd pr-282 fix regression from pr-256 GetClipboardString No longer returns an error pr-280 fix: go mod vendor pr-273 Added missing functions for compatibility with Vulkan pr-270 .travis.yml: use latest stable Go (1.13.8 and 1.12.17 at this time)
|
I think the vendor files must be out of date after this? Using “fyne vendor” will ensure the updated C and H files are included as well as the Go. |
|
if i understood you correctly that was my mistake in he first try. |
|
If you look at the changes tab for this PR there are 0 code changes present, so something doesn’t quite add up... the vendor folder should reflect all the code improvements you have listed I would think? |
|
oh! i missed |
andydotxyz
approved these changes
Jun 26, 2020
ghost
deleted the
Jacalz
added a commit
to Jacalz/fyne
that referenced
this pull request
Nov 23, 2023
See fyne-io#1136. The clipboard no longer crashes when pasting empy content (also verified locally). The clipboard also no longer require access to the window struct. Clean up the code. As the clipboard no longer needs the viewport, we can also remove a possible crash when getting a clipboard from a window that has yet to be set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in the glfw:
Description:
pulling in external dependency with the fixes preventing fyne crashes
Fixes #(issue)
#1132
#1123
#743 (claimed as fixed but the real fix is in the update that is missing)
Checklist:
Where applicable: