Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixups for strokes - add them to Software render and support larger ones in OpenGL code. #1141

Merged
merged 9 commits into from Jul 3, 2020
Merged

Fixups for strokes - add them to Software render and support larger ones in OpenGL code. #1141

merged 9 commits into from Jul 3, 2020

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Jun 26, 2020 •
edited

Fixes #831

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member Author

This is WiP as I would like to tidy the handling of this padding and make software painter do the same.
Right now I'd like to know if it fixes @ajstarks initial issue before I put more work into tidying.

@ajstarks
Copy link

I confirm that this fixes my issue.

@andydotxyz andydotxyz changed the title Expand vector pad as required by expanding vector strokes Fixups for strokes - add them to Software render and support larger ones in OpenGL code. Jun 30, 2020
@andydotxyz
Copy link
Member Author

This is now complete. As well as addressing the issue of rasterising not expanding to fill larger stroke sizes (#831) it adds in the missing circle / line / rect stroke rendering to the software canvas.

@andydotxyz andydotxyz marked this pull request as ready for review June 30, 2020 09:56
@andydotxyz andydotxyz requested a review from a team June 30, 2020 15:21
@andydotxyz andydotxyz mentioned this pull request Jun 30, 2020
Closed
Jacalz
Jacalz approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 My issues with resize are fixed and the same goes for stroke width. Wonderful :)

@andydotxyz andydotxyz merged commit 1bd0d2c into fyne-io:develop Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andydotxyz @ajstarks @Jacalz