Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resize flicker, at last :) #1150

Merged
merged 5 commits into from Jun 30, 2020
Merged

Fix resize flicker, at last :) #1150

merged 5 commits into from Jun 30, 2020

Conversation

andydotxyz
Copy link
Member

Description:

Sync threads when resizing on main, this makes draw appear the right size then returns to resizing.
Fixes most of the flicker issues. Though it re-introduces a little lag.
Now we have decent resize AND animations continue on move/resize.

Fixes #1114, #1122, #1140

Checklist:

  • Tests included. <- Just resize your window, but on lots of different OS combinations :)
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Fix flicker, tear and other artefacts on resize
2e97364 
This does add a little lag, especially on complex screens, but that is the tradeoff.
Resizing GL canvases is slow so unfortunately.

Fixes fyne-io#1114, fyne-io#1122, fyne-io#1140
@andydotxyz
Fix warnings
0e051b4
@andydotxyz
Copy link
Member Author

Tested on, and behaving very well:

  • macOS Catalina, iMac 5K
  • macOS Catalina, Mac Book Pro (2016)
  • macOS ElCapitan MacBook Pro (late 2011)
  • Arch Linux Gnome latest

@andydotxyz
Copy link
Member Author

Now working additionally on

  • Windows 10 (Dell XPS 13)

All items above tested with the additional changes

@andydotxyz andydotxyz requested a review from a team June 30, 2020 15:20
Jacalz
Jacalz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. I have tested in the following devices and seen positive results:

  • Windows 10 on Dell Latitude 5590
  • MacOS 10.13 High Sierra on IMac Mid 2011
  • Linux on Solus with Budgie desktop.

@andydotxyz andydotxyz merged commit 102ff9e into fyne-io:develop Jun 30, 2020
@eldinoyev eldinoyev mentioned this pull request Jul 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @Jacalz