Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListableURI interface & Initial Implementation thereof #1233

Merged
merged 19 commits into from
Aug 31, 2020
Merged

ListableURI interface & Initial Implementation thereof #1233

merged 19 commits into from
Aug 31, 2020

Commits on Aug 2, 2020

  1. sketch out proposed ListableURI interface

    @charlesdaniels
    charlesdaniels committed Aug 2, 2020
    Configuration menu
    Copy the full SHA
    9357bab View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. sketch out URIHandler

    @charlesdaniels
    charlesdaniels committed Aug 8, 2020
    Configuration menu
    Copy the full SHA
    f6a9083 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2020

  1. Merge branch 'develop' into listable_uri

    @charlesdaniels
    charlesdaniels committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    ee543cd View commit details
    Browse the repository at this point in the history

  2. roll-back URI handler stuff 

    As discussed in fyne-io#1233 and elsewhere, this isn't really relevant to the
listable URI stuff. It might be worth revisiting later.
    @charlesdaniels
    charlesdaniels committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    89e3661 View commit details
    Browse the repository at this point in the history

  3. initial working POC for listable URI

    @charlesdaniels
    charlesdaniels committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    f1dfdb9 View commit details
    Browse the repository at this point in the history

  4. delete temp directory in listable URI test

    @charlesdaniels
    charlesdaniels committed Aug 15, 2020
    Configuration menu
    Copy the full SHA
    04be3e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Merge branch 'develop' into listable_uri

    @charlesdaniels
    charlesdaniels committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    3749f92 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Add ListerForURI to Driver interface 

    For now, the mobile driver just returns a not implemented error.

I have also copied the implementation from glfw/file.go into
testdriver.go. Perhaps the underlying implementation should move to some
separate, common location? Like internal/urihandlers/?
    @charlesdaniels
    charlesdaniels committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    01a0c93 View commit details
    Browse the repository at this point in the history

  2. run go mod tidy

    @charlesdaniels
    charlesdaniels committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    750a401 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. Merge branch 'develop' into listable_uri

    @charlesdaniels
    charlesdaniels committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    9941dee View commit details
    Browse the repository at this point in the history

  2. fix typo

    @charlesdaniels
    charlesdaniels committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    4764685 View commit details
    Browse the repository at this point in the history

  3. explicitly declare conformance to ListableURI where appropriate

    @charlesdaniels
    charlesdaniels committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    a59c301 View commit details
    Browse the repository at this point in the history

  4. implement URIRootError 

    As discussed in today's (2020-08-21) meeting, we explicitly error with a
unique error type if the caller tries to find the parent of the root of
a URI.
    @charlesdaniels
    charlesdaniels committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    6bea744 View commit details
    Browse the repository at this point in the history

  5. rename uriRootError.go to uri_root_error.go per Stuart

    @charlesdaniels
    charlesdaniels committed Aug 22, 2020
    Configuration menu
    Copy the full SHA
    9280fec View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. switch parent to no longer be a pointer receiver 

    As discussed in #fyne-contributors, storage.Parent() is no longer a
pointer receiver to avoid breaking backwards compatibility with existing
code. Parent() is no longer a member of the URI interface. In 2.0, we
should consider moving it to be part of the URI interface.
    @charlesdaniels
    charlesdaniels committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    77c2ffb View commit details
    Browse the repository at this point in the history

  2. resolve comments on fyne-io#1233

    @charlesdaniels
    charlesdaniels committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    aecd49f View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. better error message for ListableURI implementations

    @charlesdaniels
    charlesdaniels committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b321da9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. remove copied code from testfile 

    Because the test file driver only had ListerForURI() so it would satisfy
the driver interface, but this code was not actually used, it has been
removed and replaced with a stub that returns an error message, similar
to the mobile driver.
    @charlesdaniels
    charlesdaniels committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    72df8e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'develop' into listable_uri

    @andydotxyz
    andydotxyz committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7df619a View commit details
    Browse the repository at this point in the history