Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fileitem.go #1236

Merged
merged 4 commits into from Aug 5, 2020
Merged

Update fileitem.go #1236

merged 4 commits into from Aug 5, 2020

Conversation

godcong
Copy link
Contributor

@godcong godcong commented Aug 5, 2020

fix issue #1235

Description:

Fixes #1235

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.
  • Any breaking changes have a deprecation path or have been discussed.

@Jacalz
Copy link
Member

Jacalz commented Aug 5, 2020

It looks like the Travis tests failed due to incorrect formatting. You can run the git commit hooks for easily fixing it or running formating and linters manually.

@andydotxyz
Copy link
Member

Yeah - go formatting uses tabs for indent, in this commit they are converted to spaces

@andydotxyz
Copy link
Member

Also I don't think this is the correct fix - it will only improve visibility of directory names.
I have another patch that will resolve it for files as well

@godcong
Copy link
Contributor Author

godcong commented Aug 5, 2020

Also I don't think this is the correct fix - it will only improve visibility of directory names.
I have another patch that will resolve it for files as well

Ok, if you solved this problem.
you can close it.
I just cancelled the filtering suffix name in the case of the directory
Because the directory does not need to filter the suffix

@andydotxyz
Copy link
Member

Some directories do have suffixes - like "MyApp.app" on MacOS etc.
Take a look at my fix and see what you think.

@andydotxyz andydotxyz changed the base branch from master to release/v1.3.3 August 5, 2020 20:51
@andydotxyz
Copy link
Member

Thanks, upon discussion the team agree that your change should also be landed :).

@andydotxyz andydotxyz merged commit 03c362c into fyne-io:release/v1.3.3 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dialog filter the dir name start with .
4 participants