Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #948: support focus traversal in dialogs #1318

Merged
merged 8 commits into from Sep 22, 2020
Merged

Bugfix #948: support focus traversal in dialogs #1318

merged 8 commits into from Sep 22, 2020

Commits on Sep 16, 2020

  1. name glCanvas test methods consistent (and sort them)

    @toaster
    toaster committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    4ff0519 View commit details
    Browse the repository at this point in the history

  2. manage FocusManagers per overlay

    @toaster
    toaster committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a082427 View commit details
    Browse the repository at this point in the history

  3. fix fyne-io#948: delegate focus handling for overlays to correct manager

    @toaster
    toaster committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    70255c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. add locking to glCanvas/OverlayStack

    @toaster
    toaster committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2ec5a33 View commit details
    Browse the repository at this point in the history

  2. inject current overlay focus manager into glCanvas.overlayChanged, too 

    This makes `overlayChanged` robust against concurrent changes to the overlay stack.
The locking, that was introduced into the stack earlier, already ensured
`focusMgr != prevFocusMgr` but using explicit values from the caller is
a more elegant approach which does not rely on caller’s lock.
    @toaster
    toaster committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    fb92aec View commit details
    Browse the repository at this point in the history

  3. fix deprecated overlay methods regarding locking

    @toaster
    toaster committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    b69f249 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. add clarifying comment on FocusGained/FocusLost regarding locking

    @toaster
    toaster committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    0b06e76 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bugfix/948

    @toaster
    toaster committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    8a1fa52 View commit details
    Browse the repository at this point in the history