Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Select so that it doesn't expand to fit #1345

Merged
merged 3 commits into from Oct 1, 2020

Conversation

andydotxyz
Copy link
Member

This improves select so it can have long content without expanding the app :).
Test images change as we moved to label to do this - but looking at them the alignment is better with this change!

Biggest change is that the drop-down can be larger than button.
Also button will not grow to fit selected item.

Fixes #1247

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Biggest change is that the drop-down can be larger than button.
Also button will not grow to fit selected item.

Fixes fyne-io#1247
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andydotxyz andydotxyz merged commit 67b6988 into fyne-io:develop Oct 1, 2020
@andydotxyz andydotxyz deleted the fix/1247 branch October 1, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants