Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dialog content to expand instead of use min size. #1367

Merged
merged 11 commits into from Oct 7, 2020
Merged

Fix dialog content to expand instead of use min size. #1367

merged 11 commits into from Oct 7, 2020

Conversation

okratitan
Copy link
Member

This makes dialog content expand to the size of the dialog rather than only be sized to the content's min size.

Fixes #1360

Checklist:

  • [N/A] Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • [N/A] Public APIs match existing style.
  • [N/A] Any breaking changes have a deprecation path or have been discussed.

@andydotxyz
Copy link
Member

I think you forgot to run tests before pushing...?

stuartmscott
stuartmscott previously approved these changes Oct 7, 2020
View reviewed changes
stuartmscott
stuartmscott previously approved these changes Oct 7, 2020
View reviewed changes
@okratitan okratitan merged commit a7b74d9 into fyne-io:develop Oct 7, 2020
@okratitan okratitan mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmscott stuartmscott stuartmscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okratitan @andydotxyz @stuartmscott