File dialog locations #1379
Merged
File dialog locations #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This swaps ~/ and ./ as the default directory. I have also made / the failover if both of those error. That *shouldn't* happen though. Note that / should be safe even on Windows, since NT supports POSIX-style paths. `/` should expand to NTFS's root, which is almost always `C:\`. XXX: might be worth setting the failover dir in the platform driver. `/` is probably not a good failover choice for iOS, although I'm not sure the file dialog even makes sense there, since they have their own system one? I'm not an iOS dev, so I'm not sure.
This adds the concept of a "starting directory", which may be set with a new setter method. If there is a problem with this directory, or it is an empty string, then the CWD is preferred, followed by the user home, followed by `/`. This also adds two new utility methods, ShowFileOpenAt, and ShowFileSaveAt which allow the starting directory to be explicitly set as arguments. This should not break the existing API.
Per @andydotxyz I have moved the logic to calculate the starting directory for the file dialog widget to it's own function.
This implements just the effectiveStartingDir() and a basic test from PR fyne-io#1108. It does provide the ability to set a custom starting dir. Cherry picked from fyne-io#1111 to fyne-io#1108 to avoid future merge conflicts.
Fix some issues related to ListableURI and dialog
File dialog locations
…ls/fyne into file_dialog_locations
charlesdaniels
previously approved these changes
Oct 10, 2020
|
OK that's all comments addressed. I am not certain now if StartingLocation is right - should we instead use SetLocation (so it's not start specific) or make it a Location field that can be written or read... |
Also move setDirectory to setLocation to be consistent
stuartmscott
approved these changes
Oct 10, 2020
charlesdaniels
approved these changes
Oct 10, 2020
|
Thanks for your help on this @charlesdaniels and @PucklaMotzer09, I know it's been a long haul but we got there :). |
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaces PR #1108
Fixes #821
Checklist:
Where applicable: