Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy the overlay resize code from GLFW into Gomobile #1399

Merged
merged 2 commits into from Oct 13, 2020
Merged

Copy the overlay resize code from GLFW into Gomobile #1399

merged 2 commits into from Oct 13, 2020

Conversation

andydotxyz
Copy link
Member

Fixed #1334

Checklist:

  • Tests included. <- requires mobile device, visual tests pass
  • Lint and formatter run with no errors.
  • Tests all pass.

toaster
toaster approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@toaster toaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I’m wondering if there is an aspect to GLFW and mobile canvas which could be extracted to copy code (and bugs) less.

@andydotxyz
Copy link
Member Author

Yes, unifying subsets of the code would be good. Perhaps not this close to a realease though.

@andydotxyz andydotxyz merged commit a3333e5 into fyne-io:develop Oct 13, 2020
@andydotxyz andydotxyz deleted the fix/1334 branch October 13, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toaster toaster toaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @toaster