Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opening folders. #1449

Merged
merged 5 commits into from Oct 23, 2020

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Oct 23, 2020

New constructor and show helper for folders.
This re-uses the file dialog using a standard filter for folder type (largely an internal detail for signalling).
For desktop this sets the current directory as the "selected" item so "Open" just picks this.
This does open mobile pickers as well, though the lack of ListableURI in mobile means it does not return correctly.

Proposing a new PR for completing ListableURI for mobile so that it does not hold back this functionality on desktop.

Fixes #941

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style.

This does open mobile pickers as well, though the lack of ListableURI in mobile means it does not return correctly.

Fixes fyne-io#941
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise it looks good to me. It is great to see this finally landing 👍

cmd/fyne/internal/mobile/dex.go Show resolved Hide resolved
Jacalz
Jacalz previously approved these changes Oct 23, 2020
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you :)

cmd/fyne_demo/screens/window.go Outdated Show resolved Hide resolved
@andydotxyz andydotxyz merged commit 11512e0 into fyne-io:develop Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants