Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple mouse buttons combined #1534

Merged
merged 3 commits into from Nov 16, 2020

Conversation

andydotxyz
Copy link
Member

Buttons should be additive rather than override.

Also remove old comment - that was supposed to reserve the iota, but
it got broken some time ago
Fixes #1533

Checklist:

  • Tests included. <- we still have not figured GLFW hardware based test mocks :(
  • Lint and formatter run with no errors.
  • Tests all pass.

Also remove old comment - that was supposed to reserve the iota, but
it got broken some time ago
Fixes fyne-io#1533
@MagicalTux
Copy link
Contributor

Tested and confirmed fixing issue #1533

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@andydotxyz andydotxyz merged commit ab52462 into fyne-io:release/v1.4.x Nov 16, 2020
@andydotxyz andydotxyz deleted the fix/1533 branch November 16, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants