Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iOS app upload #1546

Merged
merged 5 commits into from Nov 16, 2020
Merged

Fix iOS app upload #1546

merged 5 commits into from Nov 16, 2020

Conversation

andydotxyz
Copy link
Member

Missing xcassets and some icon keys

Fixes #1504

Checklist:

  • Tests included. <- failure is subjective according to latest Apple rules...
  • Lint and formatter run with no errors.
  • Tests all pass.

Jacalz
Jacalz approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Amazing work. Really nice seeing Fyne apps in the app store 🙂

@andydotxyz andydotxyz merged commit c186353 into fyne-io:release/v1.4.x Nov 16, 2020
@andydotxyz andydotxyz deleted the fix/1504 branch November 16, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydotxyz @Jacalz