Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where dialog shadows may not resize #1613

Merged
merged 2 commits into from Nov 27, 2020

Conversation

andydotxyz
Copy link
Member

The inner size was not updated when our content forced it to.
We cannot override it or it won't shrink again, so this fixes the calculation for shadow size.

Fixes #1370

Checklist:

  • Tests included. <- previoous tests had committed broken images, now resolved
  • Lint and formatter run with no errors.
  • Tests all pass.

The inner size was not updated when our content forced it to.
We cannot override it or it won't shrink again, so this fixes the calculation for shadow size.

Fixes fyne-io#1370
Copy link
Member

@stuartmscott stuartmscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andydotxyz andydotxyz merged commit aa105c6 into fyne-io:release/v1.4.x Nov 27, 2020
@andydotxyz andydotxyz deleted the fix/1370 branch November 27, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants