Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clipping child clips, avoid overflow of nested scroll containers #1695

Merged
merged 4 commits into from Dec 29, 2020

Conversation

andydotxyz
Copy link
Member

Fixes issue where scroll container inside scroll container would not correctly clip visuals.
Now we work how how much should be visible by intersecting with parent.

Fixes #1682

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz changed the base branch from master to develop December 29, 2020 17:34
@andydotxyz andydotxyz changed the base branch from develop to release/v1.4.x December 29, 2020 17:34
Copy link
Member

@stuartmscott stuartmscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andydotxyz andydotxyz merged commit 650aec3 into fyne-io:release/v1.4.x Dec 29, 2020
@andydotxyz andydotxyz deleted the fix/1682-2 branch December 29, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect clipping behavior when scroll containers are nested
2 participants