Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and test case for 1737 #1766

Merged
merged 6 commits into from Jan 12, 2021
Merged

Fix and test case for 1737 #1766

merged 6 commits into from Jan 12, 2021

Conversation

aayush420
Copy link
Contributor

@aayush420 aayush420 commented Jan 11, 2021 •
edited

Description:

Moves the cursor down to next line with wrapping after the line is full

Fixes #(issue)
1737

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@aayush420
Extra test to cover issue 1737
ae3e375 
New test TestEntry_CursorColumn_Wrap2 to address the bug  (1737)[fyne-io#1737]
@aayush420
Image file for visual verification of the test
2848a60 
Image file as an input to verify TestEntry_CursorColumn_Wrap2
@aayush420
Addresses the bug 1737
646bc1a 
Added an extra if condition to address the edge case
@aayush420 aayush420 mentioned this pull request Jan 11, 2021
Closed
andydotxyz
andydotxyz requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good but can you use a more sensible filename for the test artifact?

widget/entry_test.go Outdated Show resolved Hide resolved
@andydotxyz
Copy link
Member

Can we get 1 more set of eyes please? I was quite close to the implementation of this.

stuartmscott
stuartmscott suggested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@stuartmscott stuartmscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to ensure the fix works for each of the 3 types of wrapping; on, off, truncate. So far it appears only the first two are tested.

widget/entry.go Show resolved Hide resolved
@andydotxyz andydotxyz merged commit 680cb73 into fyne-io:develop Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@stuartmscott stuartmscott stuartmscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aayush420 @andydotxyz @stuartmscott