Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location of mobile popups by fixing the absolute position lookup #1792

Merged
merged 1 commit into from Jan 14, 2021

Conversation

andydotxyz
Copy link
Member

We just were not adjusting for the mobile canvas details.

We need to check the InteractiveArea for the top window (see screenshot of menu).
For child windows we also need to check there is a window head that is more than just the menu button (second screenshot).

Fixes #1771

Checklist:

  • Tests included. <- images attached until we improve mobile test infra
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Copy link
Member Author

IMG_0086
IMG_0085

@andydotxyz andydotxyz merged commit ce06fb9 into fyne-io:develop Jan 14, 2021
@andydotxyz andydotxyz deleted the fix/1771 branch January 14, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants