Fix/1809 - toolbar refresh on icon change #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should refresh the whole toolbar if asked.
Since this optimisation was put in place we have better documented the potential expense of calling Refresh - and we have done a better job of avoiding it except when needed, like in this instance.
Also removed a rogue background rectangle folloing the BackgroundColor removal.
Fixes #1809
Checklist: