Ensure Popups are resized in newly created window and when window is resized, fixes #1692

[fpabl0]

Description:

Fixes #1692 and #1382 when #1931 is landed.

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.
• Refresh dialogs correctly, fixes #1866 #1931 landed
• Add these changes to mobile driver.
• Copy fixes in FileDialog Resize method to other dialogs that use widget.PopUp too.
• Decision about Inconsistent size/position handling for overlays #707 TODO code comments. (Inconsistent size/position handling for overlays #707 is a design proposal, so it is out of scope of this PR)

[andydotxyz]

This seems to break resizing with visible dialogs:

[andydotxyz]

The changes here seem to break sizing in other areas.
Also it only has changed file dialog, not all dialogs.

[fpabl0]

This seems to break resizing with visible dialogs:

How do you test it? This solution can only be seen after #1931 is landed, as I said in the first comment.

[fpabl0]

Also it only has changed file dialog, not all dialogs.

Yes, other dialogs need the same fix. That's why I put it in the Check List in the first comment.
I will mark this as a draft to avoid confusing, sorry.

[andydotxyz]

Yes, other dialogs need the same fix. That's why I put it in the Check List in the first comment.

Ah of course, I missed that sorry. Draft seems like a good idea.

[andydotxyz]

How do you test it? This solution can only be seen after #1931 is landed, as I said in the first comment.

Open fyne_demo go to dialogs and open a file dialog.
Then resized the window.

[andydotxyz]

If you can merge in latest develop this should work now...

[fpabl0]

@andydotxyz I have updated, check if now you can see the fix :), I still need to do the same change to other dialogs, but want feedback first :)

[andydotxyz]

Thanks @fpabl0 now that it is overlayed on the other fix I don't see the issue I raised before, sorry for the confusion.
After quick testing it looks like a great fix. I'll do a proper review once you're happy with the code :)

[fpabl0]

sorry for the confusion

No worries, it was my fault, because I opened this as PR instead of a draft 😅

I'll do a proper review once you're happy with the code :)

Great! 👍 I would like to know what is exactly the issue #707, how do I test it? There are comments in the code referencing that issue that this PR will overwrite so want to know if this overwrite still satisfies that workaround.

By the way, do you know what happened with the tests? It says that it was cancelled, but no more information 🧐

[fpabl0]

Ok this is almost finished. I am not sure if I can add tests to this fix, because the real fix is actually on canvas implementation, that is overwritten in test environment 🤔

I would appreciate if @toaster can review this too, as he opened #707 and this PR is going to overwrite some things around that issue.

[andydotxyz]

Ok this is almost finished. I am not sure if I can add tests to this fix, because the real fix is actually on canvas implementation, that is overwritten in test environment 🤔

For these things the tests go in internal/driver/glfw and internal/driver/gomobile - those use driver-specific canvases instead of the test objects.

[andydotxyz]

It says that it was cancelled, but no more information 🧐

Sorry I don't know what happened - tests normally cancel if a newer commit was pushed or one of the other tests failed.
Looks like it was not a permanent failure.