Refactoring List code to remove lots of internal state that caused some render issues #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me render issues I could not track down the issues directly, so imported Tree/Table style code to render with simpler code. Fixes fyne-io#1948, fyne-io#1960
Jacalz
requested changes
Feb 23, 2021
Jacalz
previously approved these changes
Feb 23, 2021
fpabl0
reviewed
Feb 24, 2021
widget/list.go
Outdated
| } else { | ||
| objects[len(objects)-1].Move(fyne.NewPos(0, 0)) | ||
| func (l *listLayout) setupListItem(item fyne.CanvasObject, id ListItemID) { | ||
| li := item.(*listItem) |
There was a problem hiding this comment.
Is there any particular reason to receive a fyne.CanvasObject instead of directly a *listItem? 🤔
There was a problem hiding this comment.
No, a hangover from old code - thanks
fpabl0
reviewed
Feb 24, 2021
| li.selected = false | ||
| for _, s := range l.list.selected { | ||
| if id == s { | ||
| li.selected = true |
There was a problem hiding this comment.
If this is setting up a single list item, wouldn't it be more efficient to break the loop when the list item selected was found?
Jacalz
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not track down the issues directly, so imported Tree/Table style code to render with simpler code.
TODO:
Fixes #1948, #1960
Checklist: