Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry cursor animation #1968

Merged
merged 4 commits into from Mar 1, 2021
Merged

Conversation

fpabl0
Copy link
Member

@fpabl0 fpabl0 commented Feb 17, 2021

Description:

This PR is based on the chat call (12/02/2021) and the discussion on #1779.

Cursor should be static when user is interacting with the Entry.
#1778 appears, because fade animation is running when user is typing.

#1956 should be landed first to avoid memory leaks.

Fixes #1778

Checklist:

…s triggered by TypedKey method in widget.Entry, added entry cursor animation test
@fpabl0 fpabl0 mentioned this pull request Feb 17, 2021
3 tasks
@fpabl0 fpabl0 marked this pull request as draft February 17, 2021 07:41
@PresleyHank
Copy link

1
2

when I container.NewVSplit then I click the maximize window button, and then click Restore, the interference line of the table will appear in the MultiLineEntry,How to fix it ,thanks you time.:)


tabVSplitEntry := container.NewVSplit(
	table1,
	multiLineEntry1,
)

I have tried as follows:
table1.Refresh()
multiLineEntry1.Refresh()

But the Interference line still appear

@andydotxyz
Copy link
Member

Please open a new issue for this @PresleyHank

@andydotxyz
Copy link
Member

Sorry for the delay on merging the dependency, I think this is unblocked now @fpabl0.

@fpabl0
Copy link
Member Author

fpabl0 commented Feb 26, 2021

Sorry for the delay on merging the dependency

No worries :)

I think this is unblocked now

Yes, it is 👍

@fpabl0 fpabl0 marked this pull request as ready for review February 26, 2021 15:59
@andydotxyz andydotxyz merged commit 00ff55b into fyne-io:develop Mar 1, 2021
andydotxyz pushed a commit that referenced this pull request Mar 1, 2021
Add an object to handle interruptions triggered by TypedKey method in widget.Entry,
@fpabl0 fpabl0 deleted the fix/entry-cursor-anim branch March 4, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants